Add ACE-Step segmented checkpointing support - #2933
Merged
Merged
Conversation
bghira
force-pushed
the
agent/segmented-checkpointing-ace-step
branch
from
August 3, 2026 08:50
132183e to
dbbae7e
Compare
bghira
marked this pull request as ready for review
August 3, 2026 08:51
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ACE-Step model support for segmented checkpointing controls by wiring interval/segment-stride into the ACE-Step transformer and enabling the corresponding safety-check allow-lists, plus a targeted unit test to ensure the model exposes the expected control surface.
Changes:
- Add
gradient_checkpointing_intervalandgradient_checkpointing_segment_stridesetters/state toACEStepTransformer2DModel, and gate per-block checkpointing viashould_checkpoint_block(...). - Allow ACE-Step to use
--gradient_checkpointing_intervaland--gradient_checkpointing_segment_strideviasafety_checkmodel-family allow-lists. - Add a unit test covering ACE-Step’s checkpointing control availability.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_segmented_checkpointing_model_support.py | Adds a small capability-coverage test for ACE-Step segmented checkpointing controls. |
| simpletuner/helpers/training/default_settings/safety_check.py | Adds ace_step to the interval and segment-stride allow-lists for validation/normalization. |
| simpletuner/helpers/models/ace_step/transformer.py | Implements interval/segment-stride fields + setters and applies should_checkpoint_block gating during training. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghira
force-pushed
the
agent/segmented-checkpointing-ace-step
branch
2 times, most recently
from
August 3, 2026 10:45
07c7c0c to
d4f83ea
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-ace-step
branch
from
August 3, 2026 15:30
d4f83ea to
b6c0aa9
Compare
bghira
force-pushed
the
agent/segmented-checkpointing-ace-step
branch
from
August 3, 2026 15:32
b6c0aa9 to
3cfb159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the ACE-Step segmented-checkpointing integration out of #2925.
Stack
Base branch:
agent/segmented-checkpointing-baseValidation
.venv/bin/python -m unittest tests.test_segmented_checkpointing_model_support -v