Skip to content

Add ACE-Step segmented checkpointing support - #2933

Merged
bghira merged 2 commits into
mainfrom
agent/segmented-checkpointing-ace-step
Aug 3, 2026
Merged

Add ACE-Step segmented checkpointing support#2933
bghira merged 2 commits into
mainfrom
agent/segmented-checkpointing-ace-step

Conversation

@bghira

@bghira bghira commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

Splits the ACE-Step segmented-checkpointing integration out of #2925.

  • adds ACE-Step interval and segment-stride controls
  • adds ACE-Step to the relevant safety-check allow-lists
  • keeps shared runtime/docs in the base PR so this diff stays model-specific

Stack

Base branch: agent/segmented-checkpointing-base

Validation

  • .venv/bin/python -m unittest tests.test_segmented_checkpointing_model_support -v
  • commit hooks: Black, isort, flake8, whitespace checks

@bghira
bghira force-pushed the agent/segmented-checkpointing-ace-step branch from 132183e to dbbae7e Compare August 3, 2026 08:50
@bghira
bghira marked this pull request as ready for review August 3, 2026 08:51
@bghira
bghira requested a review from Copilot August 3, 2026 08:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ACE-Step model support for segmented checkpointing controls by wiring interval/segment-stride into the ACE-Step transformer and enabling the corresponding safety-check allow-lists, plus a targeted unit test to ensure the model exposes the expected control surface.

Changes:

  • Add gradient_checkpointing_interval and gradient_checkpointing_segment_stride setters/state to ACEStepTransformer2DModel, and gate per-block checkpointing via should_checkpoint_block(...).
  • Allow ACE-Step to use --gradient_checkpointing_interval and --gradient_checkpointing_segment_stride via safety_check model-family allow-lists.
  • Add a unit test covering ACE-Step’s checkpointing control availability.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/test_segmented_checkpointing_model_support.py Adds a small capability-coverage test for ACE-Step segmented checkpointing controls.
simpletuner/helpers/training/default_settings/safety_check.py Adds ace_step to the interval and segment-stride allow-lists for validation/normalization.
simpletuner/helpers/models/ace_step/transformer.py Implements interval/segment-stride fields + setters and applies should_checkpoint_block gating during training.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_segmented_checkpointing_model_support.py
@bghira
bghira force-pushed the agent/segmented-checkpointing-ace-step branch 2 times, most recently from 07c7c0c to d4f83ea Compare August 3, 2026 10:45
@bghira
bghira force-pushed the agent/segmented-checkpointing-ace-step branch from d4f83ea to b6c0aa9 Compare August 3, 2026 15:30
Base automatically changed from agent/segmented-checkpointing-base to main August 3, 2026 15:32
@bghira
bghira force-pushed the agent/segmented-checkpointing-ace-step branch from b6c0aa9 to 3cfb159 Compare August 3, 2026 15:32
@bghira
bghira merged commit 7dfe469 into main Aug 3, 2026
2 checks passed
@bghira
bghira deleted the agent/segmented-checkpointing-ace-step branch August 3, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants