feat: add replay_file_name as column in matches mart#9
Merged
p2004a merged 1 commit intobeyond-all-reason:mainfrom Apr 29, 2026
Merged
Conversation
Right now to go from a match -> replay file you have to query the bar-db api for each replay id for the filename, then download using that filename. This will allow users to skip the api call and go right to storage. Sequelize definition showing existence of this column (and that it's non-null): https://github.com/beyond-all-reason/bar-db/blob/67ee6ba47354542b23edac64dc262e85521adefd/src/model/db/demo.ts#L76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now to go from a match in the dataset to a replay file you have to query the bar-db api with a replay id, get the filename, then download from ovh storage using that filename. This will allow users to skip the api call and go right to storage.
Sequelize definition showing existence of this column (and that it's non-null): https://github.com/beyond-all-reason/bar-db/blob/67ee6ba47354542b23edac64dc262e85521adefd/src/model/db/demo.ts#L76