test(js): de-flake fingerprint determinism test (pin Span timestamp)#26
Merged
Conversation
…tamp
new Span({...}) defaults timestamp to Date.now(), so the two spans in
"same spans produce same fingerprint" got different timestamps when their
creation straddled a millisecond — making the test (and CI) intermittently
fail (seen on Node 18). Pass an explicit timestamp: 0 so the spans are
byte-identical. Test-only; no SDK behavior change.
beyhangl
added a commit
that referenced
this pull request
Jun 1, 2026
…tamp (#26) new Span({...}) defaults timestamp to Date.now(), so the two spans in "same spans produce same fingerprint" got different timestamps when their creation straddled a millisecond — making the test (and CI) intermittently fail (seen on Node 18). Pass an explicit timestamp: 0 so the spans are byte-identical. Test-only; no SDK behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS test
models.test.ts > "same spans produce same fingerprint"fails intermittently (seen on Node 18 in CI) becauseSpan.timestampdefaults toDate.now()— two spans created across a millisecond boundary hash differently. Pin an explicittimestamp: 0so the spans are byte-identical.Test-only, no SDK behavior change. Verified:
models.test.tspasses 3/3 runs; full JS suite 145/145.Note (separate decision for later): the deeper question of whether the fingerprint should include
timestampat all (it makes every re-record of identical behavior produce a different fingerprint, in both the JS and Python SDKs) is left unchanged here.