Chore/bump type versions ctrlc 3450 - #116
Amber-Cloud wants to merge 7 commits into
Conversation
…r-components-and-wit-types-PHOEN-1523 Feat/add versioning to helper components and wit types phoen 1523
Mees-Molenaar
left a comment
Mees-Molenaar
left a comment
There was a problem hiding this comment.
If those versions bump seem to be necessary we need to fix the underlying problem instead of how it is solved here.
| package betty-blocks:create@2.0.0; | ||
| package betty-blocks:create@2.1.0; | ||
|
|
||
| interface create { | ||
| use betty-blocks-types:data-api/data-api@2.0.0.{helper-context}; | ||
| use betty-blocks-types:types/types@2.0.0.{betty-model, betty-property-mapping, betty-record-json}; |
There was a problem hiding this comment.
The necessary types didnt change for the create step right? That would mean that the types dont have to be bumped and also no new version of the create should be published.
I can answer t myself I guess, no code is changed in the create step. So the types it uses are actually the same so the bumps are not relevant.
| package betty-blocks:delete@2.0.0; | ||
| package betty-blocks:delete@2.1.0; | ||
|
|
||
| interface delete { | ||
| use betty-blocks-types:data-api/data-api@2.0.0.{helper-context}; | ||
| use betty-blocks-types:types/types@2.0.0.{betty-selected-record}; |
There was a problem hiding this comment.
Same as in the create, no code changes. Types for delete are not changed so no bumps needed
| package betty-blocks:send-mail@2.0.0; | ||
| package betty-blocks:send-mail@2.1.0; | ||
|
|
||
| interface send-mail { | ||
| use betty-blocks-types:types/types@2.0.0.{json-string, betty-property-path}; |
There was a problem hiding this comment.
Same as for delete and create
There was a problem hiding this comment.
These were my changes correct? Just a note that we need to carefully test this component for if it still works. I dont fully remember anymore if I already did that.
| interface store { | ||
| use betty-blocks-types:data-api/data-api@2.0.0.{helper-context}; | ||
| use betty-blocks-types:types/types@2.0.0.{betty-model, betty-property}; | ||
| use betty-blocks-types:types/types@2.2.0.{betty-model, betty-property}; |
There was a problem hiding this comment.
Should not be needed
| import betty-blocks-types:data-api/data-api@2.0.0; | ||
| import betty-blocks-types:types/types@2.0.0; | ||
| import betty-blocks-types:upload-file/upload-file@2.0.0; | ||
| import betty-blocks-types:types/types@2.2.0; |
There was a problem hiding this comment.
Should not be needed
| package betty-blocks:update@2.1.0; | ||
|
|
||
| interface update { | ||
| use betty-blocks-types:data-api/data-api@2.0.0.{helper-context}; | ||
| use betty-blocks-types:types/types@2.0.0.{betty-property-mapping, betty-model, betty-selected-record, betty-record-json}; | ||
| use betty-blocks-types:types/types@2.2.0.{betty-property-mapping, betty-model, betty-selected-record, betty-record-json}; |
There was a problem hiding this comment.
Same as for the other steps
| package betty-blocks:upsert@2.1.0; | ||
|
|
||
| interface upsert { | ||
| use betty-blocks-types:data-api/data-api@2.0.0.{helper-context}; | ||
| use betty-blocks-types:types/types@2.0.0.{betty-property-mapping, betty-model, betty-property-path, betty-record-json}; | ||
| use betty-blocks-types:types/types@2.2.0.{betty-property-mapping, betty-model, betty-property-path, betty-record-json}; |
There was a problem hiding this comment.
Same as for the other steps
| [ -f "$path/Justfile" ] || continue | ||
| (cd "$path" && just build) | ||
| done | ||
| clean: | ||
| #!/usr/bin/env sh | ||
| for path in functions/*/*; do | ||
| [ -f "$path/Justfile" ] || continue |
| Enum.map(function_paths(), fn path -> | ||
| {_, 0} = System.cmd("just", ["build"], cd: path, into: IO.stream()) | ||
| end) | ||
| end | ||
|
|
||
| defp test_components(_args) do | ||
| "functions/*/*" | ||
| |> Path.wildcard() | ||
| |> Enum.map(fn path -> | ||
| Enum.map(function_paths(), fn path -> | ||
| {_, 0} = System.cmd("just", ["test"], cd: path, into: IO.stream()) | ||
| end) | ||
| end | ||
|
|
||
| defp function_paths do | ||
| "functions/*/*" | ||
| |> Path.wildcard() | ||
| |> Enum.filter(&File.regular?(Path.join(&1, "Justfile"))) | ||
| end |
There was a problem hiding this comment.
Are these changes really necessary?
4 participants
No description provided.