lib/crypt-sha*, lib/crypt-sm3: fix misleading comment#222
Open
RavuAlHemio wants to merge 1 commit intobesser82:developfrom
Open
lib/crypt-sha*, lib/crypt-sm3: fix misleading comment#222RavuAlHemio wants to merge 1 commit intobesser82:developfrom
RavuAlHemio wants to merge 1 commit intobesser82:developfrom
Conversation
A copied comment misrepresents the calculation step of the S byte sequence in the crypt algorithms based on SHA2 and sm3. Replace it with an actual description of what is happening.
solardiz
approved these changes
Feb 11, 2026
Collaborator
|
Thanks. FWIW, this is one of the most ridiculous aspects of SHA-crypt - a timing leak that exists for no good reason at all (not a tradeoff, just a ridiculous extra). I previously mentioned this in: #35 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A copied comment misrepresents the calculation step of the S byte sequence in the crypt algorithms based on SHA2 and sm3. Replace it with an actual description of what is happening.