Add "on this day" filter for activiteiten (limited date filter)#130
Open
wandernauta wants to merge 3 commits into
Open
Add "on this day" filter for activiteiten (limited date filter)#130wandernauta wants to merge 3 commits into
wandernauta wants to merge 3 commits into
Conversation
The view now supports either filtering by a specific date (and then showing all commissions) or filtering by a commission (and then showing recent and future entries). In theory, this is intended to help with questions like berthubert#97, but I have not been able to confirm the motions being referred to there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so the activiteiten view now supports filtering by a specific date (and then showing activity from all commissions) in addition to filtering by a commission (and then showing recent and future entries).
The existing behavior is still the default:
The new button "Datum kiezen" switches to the day-at-a-time view with a little native date picker:
Either clicking [activiteiten], clicking "Terug naar overzicht", clicking the back button, or clearing the date field will return to the existing overview.
This feature does not let users pick an arbitrary date range; there are quite a lot of activiteiten, and I wanted to avoid a situation where someone would accidentally or maliciously request all 70.000 at once.
In theory, this is intended to help with questions like #97, but I have not been able to find the motions being referred to there in my local instance.