Add create comfort command-line arguments to tkserv (--smtp-server etc)#128
Merged
Merged
Conversation
This logs all SQLite errors to stdout. This necessarily duplicates logging somewhat: if we (actually SQLiteWriter) convert the error into an exception, and that exception is logged, it is now logged twice. If we drop the exception, intending to quietly ignore it, that is now no longer quiet. Therefore, put this behind a runtime flag. The logging callback also serves as a convenient place for a debugger breakpoint. See https://sqlite.org/errlog.html for the possible messages.
The --insecure-cookie flag is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few command-line arguments to make it a bit easier to run and debug "unofficial" instances of tkserv:
--smtp-servertakes an IP address and port of a mail server to use for user invites and such, rather than being hardcoded to 10.0.0.2:25; for Mailpit one would set127.0.0.1:1025for example. Taken fromtkbot.--sender-emailand--base-urltweak the message that gets sent in such cases.--devfor now just adds some additional SQLite logging.--insecure-cookieis removed; tkserv never sends Secure cookies, with or without the flag.The
portandrootarguments are now parsed using argparse; this avoidstkservgetting confused if these are not given but flags are given.