Move title, opengraph metadata rendering to template partials#127
Open
wandernauta wants to merge 6 commits into
Open
Move title, opengraph metadata rendering to template partials#127wandernauta wants to merge 6 commits into
wandernauta wants to merge 6 commits into
Conversation
This removes the `pagemeta` required key and instead uses template inheritance to compute a page title depending on which partial is being rendered. This has the following benefits: - Views that use doTemplate (Commissies, Kamerstukdossiers, etc) can now set a proper title. - The "- OpenTK" suffix is now consistently applied. The OpenGraph metadata is not touched.
wandernauta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
pagemetaandogrequired keys, and instead uses template inheritance to compute the page title and OpenGraph metadata for each page, depending on which partial is being rendered.Besides making tkserv.cc a bit shorter, this has the following benefits:
doTemplatefunction (Commissies, Kamerstukdossiers, etc) can now set a proper title.