fix: shrink device-flow QR and tighten dialog layout - #40
Merged
Merged
Conversation
Use EC level 'L' (one QR version smaller for our URL length) and a 1-module quiet zone, saving ~6 rows. The OpenCode instructions dialog is not scrollable, so an oversized QR clips the modal on small screens.
2x2 modules per character (▘▝▖▗-style glyphs) instead of half-blocks: the v4/L matrix now takes ~19 rows and ~19 cols instead of ~19 rows and ~35 cols... i.e. half the width and half the height, so the centered dialog fits small terminals. Verified decodable to the exact verification_uri_complete with a ZXing round-trip.
Quadrant glyphs assume square terminal cells; cells are ~1:2 (w:h), so the QR rendered twice as tall as wide. Half-blocks give square pixels (1 module = 1 char wide, half a char tall). Keeps EC 'L' and a 2-module quiet zone.
Drop the '─ or ─' divider and merge the validity note into the fallback line, saving 4 rows of vertical space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vad
Förbättringar av device flow-dialogen efter manuell testning i opencode TUI (uppföljning till #39):
M → Lräcker för vår URL-längd → QR version 4 (33×33) istället för 5. Sparar flera terminalrader — viktigt eftersom opencodes instructions-dialog inte scrollar och är vertikalt centrerad.─ or ─-dividern borttagen, giltighetstiden ihopslagen med fallback-raden (−4 rader).Testat