Skip to content

fix: add repository.url to package.json (required for npm provenance) - #87

Merged
bergetbjork merged 1 commit into
mainfrom
fix/npm-repository-url
Sep 7, 2026
Merged

bergetbjork merged 1 commit into
mainfrom
fix/npm-repository-url

Conversation

@bergetbjork

Copy link
Copy Markdown
Contributor

OIDC trusted publishing got as far as signing the provenance statement, then E422: package.json: repository.url is "", expected to match https://github.com/berget-ai/cli. Adds the missing field.

npm OIDC trusted publishing validates that package.json repository.url
matches the GitHub repo from the signed provenance statement — ours was
empty, causing E422 on publish.
@bergetbjork
bergetbjork merged commit eff27de into main Sep 7, 2026
2 checks passed
@bergetbjork
bergetbjork deleted the fix/npm-repository-url branch September 7, 2026 15:26
Comment thread package.json
"prettier --write"
]
},
"repository": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 warning — Identical repository block already merged to main in eff27de (PR #87) — this PR is now a redundant no-op and should be closed.

Comment thread package.json
},
"repository": {
"type": "git",
"url": "git+https://github.com/berget-ai/cli.git"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good — URL matches the actual origin remote (github.com/berget-ai/cli), which is what npm provenance validation requires.

@berget-ai

berget-ai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review

Summary

Adds a repository field to package.json (git+https://github.com/berget-ai/cli.git) to satisfy npm OIDC trusted publishing / provenance validation.

Risk

LOW — the change itself is correct and harmless, but the PR is fully redundant: the byte-identical repository block already landed on main in commit eff27de (PR #87, "add repository.url to package.json — required for npm provenance"), leaving this PR a no-op on top of a stale base.

Issues

  • warning package.json:85 — this exact repository block, including the identical URL, is already present on main via commit eff27de (PR fix: add repository.url to package.json (required for npm provenance) #87); git diff origin/main HEAD -- package.json shows zero remaining delta for this change, so merging this PR produces nothing new — close it as superseded/duplicated by fix: add repository.url to package.json (required for npm provenance) #87.
  • nit package.json:3 — branch is stale (merge-base 414da05; main has advanced to eff27de + release 2.2.23, PR head still shows 2.2.22); verified there is no semantic conflict — both branches made identical lint-staged-adjacent additions, so git resolves cleanly and the version field will not be regressed by a merge since this PR's commit doesn't touch it.

Suggestions

  • package.json — close this PR instead of merging; eff27de on main already contains the identical fix, and a merge would only add a duplicate commit to history.

Architecture

No structural change — 4 lines of npm package metadata.

CodeSense score: 9/10 — the change is minimal, correct, and verified against the real origin remote (https://github.com/berget-ai/cli), which is exactly what npm provenance E422 validation requires; the only flaw is that it duplicates an already-merged change.

Inline findings


Berget AI (berget/zai-org/GLM-5.3-Flash) | PR #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant