Skip to content

ci(publish): switch to npm OIDC trusted publishing #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergetbjork merged 1 commit into from
Sep 7, 2026
Merged

ci(publish): switch to npm OIDC trusted publishing #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: write
# OIDC trusted publishing (npmjs.com → berget → Trusted Publisher:
# berget-ai/cli / publish.yml). No NPM_TOKEN needed — the old classic
# token expired, which made npm publish fail with a misleading 404.
id-token: write

@berget-ai berget-ai Bot Sep 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ good — Dropping the long-lived NPM_TOKEN in favor of short-lived OIDC trusted publishing is the right security posture.

steps:
# The repo ruleset requires PRs for GITHUB_TOKEN pushes to main.
# Checking out with the repo Deploy Key (SSH) makes the version-bump
Expand Down Expand Up @@ -72,7 +76,7 @@ jobs:
npm version ${{ inputs.bump }} -m "release: %s"
git push --follow-tags

- name: Publish to NPM
run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Publish to NPM (OIDC trusted publishing)
run: |
npm install -g npm@latest # OIDC trusted publishing needs npm >= 11.5.1

@berget-ai berget-ai Bot Sep 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 warning — npm install -g npm@latest is unpinned — a new/bad npm release can break (or compromise) the publish step; pin e.g. npm@11.5.1 or npm@^11.5.1.

npm publish
Loading