Add support for altitude#9
Open
mcbridejc wants to merge 4 commits into
Open
Conversation
Owner
|
I'd prefer to not merge as is, as I don't like breaking APIs. I'd suggest the one or both of the following: 1: Add a get_altitude() method. Thanks for the contribution. |
Update pexif.py to run in Python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests allows set_geo and get_geo to set/get the GPSAltitude tag as well at the lat/lng.
Unfortunately, this is not backwards compatible, because get_geo now returns a 3-tuple instead of a 2-tuple. The line
lat, lng = my_file.get_geo()will fail with "ValueError: too many values to unpack". Instead, one should uselat, lng, alt = my_file.get_geo().I'll leave it up to the pexif maintainer(s) whether it's worth including this in the project or not. In any case, thanks for sharing pexif; it made my life easier today.