Skip to content

log all errors, add debug-flag - #5

Open
avoidik wants to merge 2 commits into
benkehoe:mainfrom
avoidik:debug-flag
Open

log all errors, add debug-flag#5
avoidik wants to merge 2 commits into
benkehoe:mainfrom
avoidik:debug-flag

Conversation

@avoidik

@avoidik avoidik commented Aug 14, 2023

Copy link
Copy Markdown

hello,

with this change I would like to propose the following:

  • log all errors to console, so that we will be able to see all errors not just 2
  • add debug-flag, to be able to snoop into the headers and raw responses
  • minor change in the command-line parameters processing code (pointers to variables)
  • get rid of fmt

@benkehoe

Copy link
Copy Markdown
Owner

I would like to continue to use fmt for all program usage errors and the version command, but the switch to log for printing identity does make sense.

Why do you want to change the parameter variable style?

@benkehoe

Copy link
Copy Markdown
Owner

Let's make the "log all errors" when debug is set but keep the existing "only log internal errors" when it's not set. The point is, e.g., 404s don't need to be logged, only unexpected problems from the code.

@avoidik
avoidik force-pushed the debug-flag branch 2 times, most recently from b1f2bd6 to 2c80e18 Compare August 25, 2025 16:58
@avoidik

avoidik commented May 8, 2026

Copy link
Copy Markdown
Author

I made changes as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants