feat: Format function names with qualname for Python 3.11+#825
Open
jake-kramer wants to merge 1 commit intobenfred:masterfrom
Open
feat: Format function names with qualname for Python 3.11+#825jake-kramer wants to merge 1 commit intobenfred:masterfrom
jake-kramer wants to merge 1 commit intobenfred:masterfrom
Conversation
This change will update function names to have module paths in them which is useful for disambiguating functions when viewing a profile. See https://docs.python.org/3/glossary.html#term-qualified-name
Owner
|
Hi @jake-kramer - this PR looks good to me, can you update to the latest main branch and I will try to start CI on this ? (I don't seem to be able to update your branch from here) |
Author
|
Thanks @benfred, I can get to this next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will update function names to have module paths in them which is useful for disambiguating functions when viewing a profile.
See https://docs.python.org/3/glossary.html#term-qualified-name