Repository navigation
chore(test): federation harness builds under its own image tag - #311
Merged
Merged
Conversation
…loses #310) docker-compose.yml hardcoded ghcr.io/benders/poutine:latest, so every local `pnpm test:federation` (`up --build`) retagged the image live hubs run. The hub image is now `${POUTINE_IMAGE:-ghcr.io/benders/poutine:latest}` and the harness exports POUTINE_IMAGE=poutine-federation-test:local (override: FEDERATION_TEST_IMAGE). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
benders
marked this pull request as ready for review
November 12, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #310.
Change
docker-compose.yml: hub image is${POUTINE_IMAGE:-ghcr.io/benders/poutine:latest}(same pattern asNAVIDROME_IMAGE). Default unchanged.test/federation/run.sh: exportsPOUTINE_IMAGE=poutine-federation-test:local(override withFEDERATION_TEST_IMAGE), so the harness'sup --buildno longer retags the local:latestthat live hubs run.docs/pitfalls.md,docs/hub-internals.md: rule and harness note updated.Verification
docker compose configresolves toghcr.io/benders/poutine:latestby default and topoutine-federation-test:localwith the harness's invocation.poutine-federation-test:localgot the new image; theghcr.io/benders/poutine:latestimage id was unchanged.pnpm verifygreen (hub 987, frontend 193, integration 22 passed / 8 skipped).pnpm test:federationnot run locally (three extra stacks OOM-killed a live hub on this host earlier today); the CIfederationjob exercises the harness end to end.🤖 Generated with Claude Code