Skip to content

chore(test): federation harness builds under its own image tag - #311

Merged
benders merged 1 commit into
mainfrom
feature/310-federation-test-image-tag
Nov 12, 2026
Merged

benders merged 1 commit into
mainfrom
feature/310-federation-test-image-tag

Conversation

@benders

@benders benders commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Closes #310.

Change

  • docker-compose.yml: hub image is ${POUTINE_IMAGE:-ghcr.io/benders/poutine:latest} (same pattern as NAVIDROME_IMAGE). Default unchanged.
  • test/federation/run.sh: exports POUTINE_IMAGE=poutine-federation-test:local (override with FEDERATION_TEST_IMAGE), so the harness's up --build no longer retags the local :latest that live hubs run.
  • docs/pitfalls.md, docs/hub-internals.md: rule and harness note updated.

Verification

  • docker compose config resolves to ghcr.io/benders/poutine:latest by default and to poutine-federation-test:local with the harness's invocation.
  • Built the hub through the harness's compose invocation: poutine-federation-test:local got the new image; the ghcr.io/benders/poutine:latest image id was unchanged.
  • pnpm verify green (hub 987, frontend 193, integration 22 passed / 8 skipped).
  • Full pnpm test:federation not run locally (three extra stacks OOM-killed a live hub on this host earlier today); the CI federation job exercises the harness end to end.

🤖 Generated with Claude Code

…loses #310)

docker-compose.yml hardcoded ghcr.io/benders/poutine:latest, so every
local `pnpm test:federation` (`up --build`) retagged the image live hubs
run. The hub image is now `${POUTINE_IMAGE:-ghcr.io/benders/poutine:latest}`
and the harness exports POUTINE_IMAGE=poutine-federation-test:local
(override: FEDERATION_TEST_IMAGE).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@benders
benders marked this pull request as ready for review November 12, 2026 01:11
@benders
benders merged commit 02d386b into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test:federation should not retag the local ghcr.io/benders/poutine:latest image

1 participant