Add deduplication of LS in lumi reader#45
Open
kdlong wants to merge 1 commit into
Open
Conversation
Owner
|
Hmm, I could have sworn the original implementation was already supposed to handle the deduplication, but maybe not... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure what causes this, but I think having sparse nanoaod files that have events from the same lumi split over multiple files causes the run,lumi combos to get added in multiple places and then double counted in the sum. This is a Claude Code solution, it stores the run,lumi combos in a set to avoid counting them twice.
It could be that simply updating the original producer to have this behaviour by default is better. I don't think the performance difference should matter much.