Skip to content

CI: add a CI run - #53

Merged
ev-br merged 8 commits into
benchx-dev:mainfrom
ev-br:set_up_ci
Oct 13, 2026
Merged

ev-br merged 8 commits into
benchx-dev:mainfrom
ev-br:set_up_ci

Conversation

@ev-br

@ev-br ev-br commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Run the prototype's test in CI, closes https://github.com/rok/benchx/issues/51

The plan is to run self-tests + pyperf and archery examples.

@rok could you activate the GH Actions in this repository please? (or give me permissions to). For now, I'm iterating with this PR on my fork, ev-br#2

@ev-br

ev-br commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

Currently ev-br#2 shows that it the tests and examples run on linux and macos. On windows, there are several issues: https://github.com/rok/benchx/issues/54 and something else. Plus, the archery-local example assumes POSIX somewhere, so is currently skipped on the CI.

Not sure if full Windows support is a top prio right now. I'm tempted to skip/xfail windows and move on. Thoughts?

rok added a commit that referenced this pull request Oct 13, 2026
GitHub does not dispatch pull_request runs for a workflow that exists only
in a pull request from a fork; the base repository must already carry a
workflow on its default branch. This placeholder bootstraps Actions so
PR #53, which brings the real workflow, can run.
@rok

rok commented Oct 13, 2026

Copy link
Copy Markdown
Member

@ev-br I can't make you admin of this repo (probably because it's not under an org, but actions are active. They probably weren't starting because workflow.yaml hasn't existed before. I rebased this PR on #56 and now things seem to be working.

@ev-br

ev-br commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @rok ! It now runs indeed and shows the expected status: linux and macos are green, windows is red. Does the red cross sign next to the windows job bother you (or anyone else) enough to skip/xfail/fix them before merging?

@rok

rok commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

I kind of expect that os to fail :)

edit: to be clear, it does not bother me at all

@raulcd

raulcd commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

To be honest we could just remove windows-latest from the runners and add it later on.

Comment thread .github/workflows/tests.yml Resolved
It fails all around: benchx-devgh-54 and other `os.` related failures.

Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@ev-br

ev-br commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

The windows CI run is gone per review suggestion, and the rest is apporved. Merging. Thanks for the reviews and help @rok, @raulcd !

@ev-br
ev-br merged commit c10faca into benchx-dev:main Oct 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a CI run for the prototype and examples

3 participants