Repository navigation
Conversation
…elpful A filter that named a parametrized benchmark but gave its arguments in the wrong order was refused with the first ten benchmark names, on one long line, with the filter shown as a Python string (`\.` as `\\.`). The refusal is now one fact per line: - the filter as typed; - when the filter, up to its first `\(`, matches the name of a parametrized benchmark, how its cases are searched: `name(p0, p1)`, each as its repr, in the order of `param_names`, with the parameters of that benchmark and one case; - the benchmarks similar to the filter (words of 3+ characters compared with the dotted parts of each name, difflib ratio >= 0.75, the names matching the most words first, 5 at most), else the first 5 available. Only the text of the refusal changes: not what a filter selects, no schema, no new option. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small UI tweak, split off gh-118.
For parametrized benchmarks it's easy to mis-type a name, especially when selecting subsets of parameters. The resulting error on main is... unhelpful:
With this PR, the error message is a tad saner: