Remove POST restart API server

lib/api_server/Cargo.toml

@@ -38,7 +38,6 @@ schemars = { workspace = true, optional = true }
 serde = { workspace = true, optional = true }
 serde_json.workspace = true
 slog.workspace = true
-tokio = { workspace = true, features = ["fs"] }
 
 [dev-dependencies]
 bencher_api_tests.workspace = true

lib/api_server/src/backup.rs

@@ -1,5 +1,5 @@
 use bencher_endpoint::{CorsResponse, Endpoint, Post, ResponseCreated};
-use bencher_json::{JsonBackup, JsonBackupCreated, JsonRestart};
+use bencher_json::{JsonBackup, JsonBackupCreated};
 use bencher_schema::{
     context::ApiContext,
     error::bad_request_error,
@@ -17,7 +17,7 @@ use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 }]
 pub async fn server_backup_options(
     _rqctx: RequestContext<ApiContext>,
-    _body: TypedBody<JsonRestart>,
+    _body: TypedBody<JsonBackup>,
 ) -> Result<CorsResponse, HttpError> {
     Ok(Endpoint::cors(&[Post.into()]))
 }

lib/api_server/src/lib.rs

@@ -3,10 +3,11 @@
 use bencher_api_tests as _;
 #[cfg(test)]
 use http as _;
+#[cfg(test)]
+use tokio as _;
 
 mod backup;
 mod config;
-mod restart;
 mod root;
 mod spec;
 mod stats;
@@ -32,14 +33,12 @@ impl bencher_endpoint::Registrar for Api {
         if http_options {
             api_description.register(version::server_version_options)?;
             api_description.register(spec::server_spec_options)?;
-            api_description.register(restart::server_restart_options)?;
             api_description.register(config::server_config_options)?;
             api_description.register(config::server_config_console_options)?;
             api_description.register(backup::server_backup_options)?;
         }
         api_description.register(version::server_version_get)?;
         api_description.register(spec::server_spec_get)?;
-        api_description.register(restart::server_restart_post)?;
         api_description.register(config::server_config_get)?;
         api_description.register(config::server_config_console_get)?;
         api_description.register(backup::server_backup_post)?;

lib/bencher_api_tests/src/context.rs

@@ -15,7 +15,7 @@ use diesel::{
 };
 use dropshot::{ApiDescription, ConfigDropshot, ConfigLogging, ConfigLoggingLevel, HttpServer};
 use tempfile::NamedTempFile;
-use tokio::sync::{Mutex, mpsc};
+use tokio::sync::Mutex;
 
 const ISSUER: &str = "http://localhost:3000";
 
@@ -95,7 +95,6 @@ impl TestServer {
         // Build minimal ApiContext
         let token_key = TokenKey::new(ISSUER.to_owned(), &DEFAULT_SECRET_KEY);
         let rbac = init_rbac().expect("Failed to init RBAC").into();
-        let (restart_tx, _restart_rx) = mpsc::channel(1);
 
         let database = Database {
             path: PathBuf::from(&db_path),
@@ -116,7 +115,6 @@ impl TestServer {
             rbac,
             messenger: Messenger::default(),
             database,
-            restart_tx,
             rate_limiting: bencher_schema::context::RateLimiting::max(),
             github_client: None,
             google_client: None,
@@ -182,7 +180,6 @@ impl TestServer {
         // Build minimal ApiContext
         let token_key = TokenKey::new(ISSUER.to_owned(), &DEFAULT_SECRET_KEY);
         let rbac = init_rbac().expect("Failed to init RBAC").into();
-        let (restart_tx, _restart_rx) = mpsc::channel(1);
 
         let database = Database {
             path: PathBuf::from(&db_path),
@@ -201,7 +198,6 @@ impl TestServer {
             rbac,
             messenger: Messenger::default(),
             database,
-            restart_tx,
             clock: bencher_json::Clock::System,
         };
 

lib/bencher_config/src/config_tx.rs

@@ -41,7 +41,6 @@ use dropshot::{
     ConfigTls, HttpServer,
 };
 use slog::{Logger, debug, error, info};
-use tokio::sync::mpsc::Sender;
 
 #[cfg(feature = "plus")]
 use super::plus::Plus;
@@ -52,7 +51,6 @@ const SQLITE_TMPDIR: &str = "SQLITE_TMPDIR";
 
 pub struct ConfigTx {
     pub config: Config,
-    pub restart_tx: Sender<()>,
 }
 
 #[derive(Debug, thiserror::Error)]
@@ -106,7 +104,7 @@ impl ConfigTx {
     where
         R: Registrar,
     {
-        let ConfigTx { config, restart_tx } = self;
+        let ConfigTx { config } = self;
 
         let Config(JsonConfig {
             console,
@@ -129,7 +127,6 @@ impl ConfigTx {
             request_body_max_bytes,
             smtp,
             database,
-            restart_tx,
             #[cfg(feature = "plus")]
             plus,
         )
@@ -176,7 +173,6 @@ impl ConfigTx {
 }
 
 #[expect(
-    clippy::too_many_arguments,
     clippy::too_many_lines,
     reason = "Context initialization needs to handle DB setup, PRAGMAs, migrations, and pool creation"
 )]
@@ -187,7 +183,6 @@ async fn into_context(
     request_body_max_bytes: usize,
     smtp: Option<JsonSmtp>,
     json_database: JsonDatabase,
-    restart_tx: Sender<()>,
     #[cfg(feature = "plus")] plus: Option<JsonPlus>,
 ) -> Result<ApiContext, ConfigTxError> {
     let console_url: url::Url = console.url.try_into().map_err(ConfigTxError::Endpoint)?;
@@ -313,7 +308,6 @@ async fn into_context(
         rbac,
         messenger: smtp.into(),
         database,
-        restart_tx,
         #[cfg(feature = "plus")]
         rate_limiting,
         #[cfg(feature = "plus")]

lib/bencher_json/src/lib.rs

@@ -106,7 +106,6 @@ pub use system::{
     auth::{JsonAccept, JsonAuthAck, JsonAuthUser, JsonConfirm, JsonLogin, JsonSignup},
     backup::{JsonBackup, JsonBackupCreated},
     config::{JsonConfig, JsonConsole},
-    restart::JsonRestart,
     spec::JsonOpenApiSpec,
     version::JsonApiVersion,
 };

lib/bencher_json/src/system/mod.rs

@@ -2,7 +2,6 @@ pub mod auth;
 pub mod backup;
 pub mod config;
 pub mod payment;
-pub mod restart;
 pub mod server;
 pub mod spec;
 pub mod version;

lib/bencher_schema/src/context/mod.rs

@@ -11,7 +11,6 @@ use bencher_oci_storage::OciStorage;
 use bencher_token::TokenKey;
 #[cfg(feature = "plus")]
 use dropshot::HttpError;
-use tokio::sync::mpsc::Sender;
 use url::Url;
 
 #[cfg(feature = "plus")]
@@ -52,7 +51,6 @@ pub struct ApiContext {
     pub rbac: Rbac,
     pub messenger: Messenger,
     pub database: Database,
-    pub restart_tx: Sender<()>,
     #[cfg(feature = "plus")]
     pub rate_limiting: RateLimiting,
     #[cfg(feature = "plus")]

services/api/Cargo.toml

@@ -81,6 +81,8 @@ bencher_schema.workspace = true
 bencher_otel = { workspace = true, optional = true }
 bencher_otel_provider = { workspace = true, optional = true }
 dropshot.workspace = true
+futures-concurrency.workspace = true
+futures-util.workspace = true
 libsqlite3-sys.workspace = true
 sentry = { workspace = true, optional = true }
 serde_yaml.workspace = true