Repository navigation
Launch the TUI on a fresh install and open on Add collection - #220
Merged
Merged
Conversation
`fnd tui` exited 1 when no index existed, so a new user could not reach the Settings UI to add their first collection. The app already copes with a missing index; only the CLI guard refused. - `prompt_and_rebuild_or_exit(missing_ok=True)` from `fnd tui`: an absent index launches the app. A stale schema still prompts; `fnd search` still refuses. - With no collections and no index, the app opens on Add collection. - An empty scope over a config that had no collections reseeds from `defaults.collection` on the next panel refresh, so the first collection (wizard or config file) is searched without a relaunch. Nothing is persisted, so later collections still seed on relaunch. - The main footer re-renders when its screen is active again: it was last rendered for the wizard's focus and offered `q` to the query bar. - A search with no searcher opens an index built by the CLI meanwhile.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 77.42% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 31 functions across 7 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly summarises the main change: launching the TUI on a fresh install and opening the Add Collection flow. Description check The description directly explains the fresh-install launch behaviour, collection wizard flow, scope handling, index handling, tests, and out-of-scope work. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit, quick to hop,
The TUI starts without a stop.
A fresh install brings the wizard near,
The first collection joins the sphere.
Ready indexes help searches run,
I nibble greens beneath the sun.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fresh install could not start the TUI:
fnd tuiexited 1 with "no index at ...", so the Settings UI was unreachable for adding the first collection. The app itself already opens without an index; the CLI guard was the only blocker.fnd tuipassesmissing_ok=Truetoprompt_and_rebuild_or_exit. An absent index launches; a stale schema still prompts;fnd searchstill refuses.FNDApppushesAddCollectionWizardon mount (as the README's Quick start already describes).ScopeController._seed_first_collectionsreseeds an empty scope fromdefaults.collectionwhen the config previously had no collections. Covers the wizard, the config-file editor and config recovery (all go throughrefresh_collections_panel). Never persists, so a later CLI-added collection still seeds on relaunch.screen_change_signalwhen the main screen is active again. It was rendered for the wizard's focus, so after Esc it showedq Quitwhileqtyped into the query bar.on_reindex_complete), rather than returning nothing until relaunch.invoked="tui"branch of_next_step.Test plan
tests/test_a_fresh_install_opens_on_add_collection.py: launch path, wizard on fresh install plus two controls (configured collection, existing index), footer after Esc, first-collection scope (and no state written), emptied-scope control, config-file reload with two collections, outside-built index. Each fails with its fix removed.make test-fastgreen;make batch-closegreen on the rebased tree.u, search finds the file with1/1 active; Esc from the wizard gives the query-bar footer andqquits.Parked (pre-existing, out of scope): deleting or renaming a collection does not prune its name from the scope selection.