Repository navigation
Bring the README up to date with the app, add a screenshot, and bump Pillow - #219
Merged
Merged
Conversation
The README had drifted from the app: - Space (Quick Look) was removed in #16 but still documented. - n/b, z (Reading View), r/p/c/f, X, Ctrl+Y, Ctrl+Enter and custom keybindings were missing. - Settings paths named menus that no longer exist (Indexing, Cache size, Cache maintenance, Reindex); the app now says Indexing & PDF Texture, PDF Texture Cache and Update index. - After installing the texturising engine it said to reindex, which skips unchanged PDFs; Texturise flat PDFs is the step. - "60 file types" (there are 40), --kind and kind: listed five types and no categories, result_limit showed 200 (default 50), pipx was said to bring Python, "repeat --source" (the CLI takes one per command), "no network" (semantic search downloads its model), and an intent: DSL credited in the acknowledgements does not exist. Also: - Quick start is now a getting-started guide (TUI first, then CLI), with an Obsidian section; `fnd <query> -c <collection>` leads the command table as the usual way in. - Markdown leads every list of file types; the description leads with local and private, BM25 ranking and the TUI. - Platform status was stated four times; now once. - The screenshot uses an absolute URL so it renders on PyPI too. - Three tests matched README table rows by exact spacing, which a markdown formatter's column padding broke; they now match by pattern.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pip-audit flags CVE-2026-112895 and seven others in Pillow 12.3.0, all fixed in 13.0.0. Pillow arrives only through python-pptx, which accepts any Pillow>=3.3.2; fnd itself never imports PIL. Lock-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README had drifted from the app, and much of it was long-form prose.
Space(Quick Look) was removed in Native text selection & copy by default (+ Reading View, opt-in mouse) #16 but still documented.n/b(match navigation),z(Reading View),r/p/c/fpane focus,Xclear filters,Ctrl+Ycopy query as command,Ctrl+Enterbatch toggle, custom keybindings.--kind/kind:listed five types and no categories,result_limit = 200(default 50), pipx "brings Python", "repeat--source" (the CLI takes one per command), "no network" (semantic search downloads its model), and anintent:DSL credited in the acknowledgements does not exist.:was described as opening Settings from anywhere; in the query bar it types a colon.Changes
assets/fnd_screenshot_sml.jpg, by absolute URL so it renders on PyPI too (the README is thefndrlong description). It shows once this is onmain.fnd <query> -c <collection>, the usual way in.Also: Pillow 13.0.0
main's scheduled run.python-pptx(Pillow>=3.3.2); fnd never imports PIL. Lock-only change.Verification
fnd binary tree -c notesdriven in the real TUI in tmux on a fresh HOME.| Filter | What it does |no longer occurs in the formatted README.make batch-closewith Pillow 13.0.0: 6353 passed, ruff and pyright clean, 12 harness scenarios passed (1 skipped, needs real corpus).Depends on
fndexits with "No collections yet"; that fix is in progress separately.