Repository navigation
Leave the config alone when only its generated comments differ - #184
Merged
Merged
Conversation
The startup migration compared its render against the file byte for byte, so two builds that word a settings hint differently rewrote each other's config on every switch, each time printing "config updated, adopt the canonical layout" and leaving another backup. It now rewrites only when the parsed values differ.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The test reached its stale-map state through `Screen._refresh_layout(scroll=True)`, which takes Textual's visible-only fast path only while no widget has a layout pending. On a slow runner one did, the screen reflowed in full, and the test's own precondition failed on Windows. It now calls `Compositor.reflow_visible`, the fast path itself. With a pending layout injected, the old setup fails with the CI message and this one passes; it still catches a single derived offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ensure_current, which compared its render of the config against the file byte for byte.fnd: config updated, adopt the canonical layoutand left another timestamped backup, though no setting had changed.Fix
ensure_currentreturns early when the file and the render parse to the same TOML values.config_version, or a value in a non-canonical form such as an absolute home path.Tests
~.make batch-close: ruff, pyright, 4911 passed / 3 skipped, all tmux harness scenarios pass.