chore: pin Rust toolchain to 1.96.0 (prevent floating-stable CI breakage)#31
Merged
Conversation
Root cause of the recent CI breakage: CI used a floating `dtolnay/rust-toolchain@stable`, so when the runners moved to Rust 1.96 the new/strengthened clippy lints turned already-committed code into hard `-D warnings` errors — breaking master and every branch with zero code changes. Local dev was also on an older stable, so local clippy disagreed with CI. Fix: pin the toolchain in one place that both local and CI honor. - Add rust-toolchain.toml (channel 1.96.0 + clippy/rustfmt components); rustup reads this for every cargo invocation, so local == CI. - Pin all four `dtolnay/rust-toolchain@stable` steps to `@1.96.0` to match. Toolchain bumps are now deliberate: change both files together and fix any new lints in the same PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recent CI outage had a single root cause: CI used a floating
dtolnay/rust-toolchain@stable. When GitHub's runners moved to Rust 1.96, new/strengthened clippy lints (sort_by_key, redundantinto_iter,collapsible_match) turned already-committed code into hard-D warningserrors — breaking master and every branch with zero code changes. Local dev was on an older stable, so local clippy silently disagreed with CI.What
Pin the toolchain in one place that both local and CI honor:
rust-toolchain.toml—channel = "1.96.0"+clippy/rustfmtcomponents.rustupreads this on everycargoinvocation, so local clippy is now identical to CI (the exact thing that made the first fix attempt falsely pass locally)..github/workflows/ci.yml— all fourdtolnay/rust-toolchain@stablesteps pinned to@1.96.0.1.96.0is exactly whatstablecurrently resolves to (hashac68faa20), so this keeps the currently-green state — no new lints introduced by this PR.Bumping later
Deliberate, not automatic: change
channelinrust-toolchain.tomland the four@1.96.0pins together in one PR, then fix any new lints that release surfaces. (Documented in the toml header.)Test plan
rustupresolves the repo to 1.96.0 via the toml locally