bug(time_format): Force mutability on return from suncalc pandas data#32
Merged
GalenReich merged 1 commit intobellingcat:mainfrom Feb 13, 2026
Merged
bug(time_format): Force mutability on return from suncalc pandas data#32GalenReich merged 1 commit intobellingcat:mainfrom
GalenReich merged 1 commit intobellingcat:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #31 --
The suncalc library returns a dictionary with pandas Series/Index objects depending on the input. When passed a pandas DatetimeIndex, the returned altitude values retain that Index type, which is immutable. This fix follows the pattern in the repo to allow mutation of altitudes.