Conversation
magsko
commented
Oct 1, 2025
magsko
commented
- Implemented exact search matching by applying reg-ex to the FTS results
- Added separate snippet generation for exact match so that that exact matches are highlighted
- Added a checkbox for exact match
GalenReich
force-pushed
the
exact-search-match
branch
from
eb8df16 to
971f2cc
Compare
GalenReich
left a comment
GalenReich
left a comment
There was a problem hiding this comment.
Thanks for the PR, I have a couple of tweaks to ask of you:
-
Could you avoid committing unrelated changes to project env files - if there is a problem with these, please open an issue and we can solve this together separately
-
Please revert whitespace changes, a couple of files have moved from tabs of 4 spaces to 2 spaces
-
More substantially, I find the exact search to be very slow and am concerned that the current algorithm could put users off the tool. Perhaps a different search approach would work better. I am also not sure if it is the search or the timestamp generation that is causing the bulk of delay - some investigation here would be useful
There was a problem hiding this comment.
Please remove this file, feel free to add it to .gitignore if neeeded
There was a problem hiding this comment.
Please restore the .env file and try to avoid touching project structure files
There was a problem hiding this comment.
I feel like there is some line ending weirdness happening here, one to watch out for.
There was a problem hiding this comment.
Please restore this file
| <v-col cols="12"> | ||
| <v-row class="mb-1" justify="end"> | ||
| <v-col cols="auto"> | ||
| <v-checkbox |
There was a problem hiding this comment.
It would be great to place the checkbox just below the search bar, rather than above it - I think it could be confusing for users otherwise
There was a problem hiding this comment.
Please revert whitespace changes
2 participants
