Skip to content

Fix AutoCAD-MCP runtime and validation issues - #1

Closed
vitungduonngg wants to merge 2 commits into
beiming183-cloud:mainfrom
vitungduonngg:vitungduonngg-curly-waffle
Closed

Fix AutoCAD-MCP runtime and validation issues#1
vitungduonngg wants to merge 2 commits into
beiming183-cloud:mainfrom
vitungduonngg:vitungduonngg-curly-waffle

Conversation

@vitungduonngg

@vitungduonngg vitungduonngg commented Oct 3, 2026

Copy link
Copy Markdown

Summary

  • Fix PID module initialization and safety checks
  • Harden payload validation and error handling
  • Improve resource cleanup and portable IPC path config
  • Validate core runtime behavior with headless demo

Testing

  • Python syntax validation across source files
  • Headless DXF/PNG demo run
  • Core test subset pass

Copilot and others added 2 commits October 2, 2026 17:21
Fix 12 identified errors: module initialization, payload validation, …
66cd613 
…resource cleanup, error handling, path portability

Critical fixes:
- PID module: proper initialization with CTO library exports
- Payload validation: safe dict access with .get() defaults
- Screenshot type safety: explicit type checking for bytes/str/dict
- CommandResult: standardized payload serialization

High-priority fixes:
- Plot error detection: improved error code mapping for specific plot failures
- IPC path: dynamic tempfile initialization with fallback chain
- Exception context: added optional traceback parameter

Medium-priority fixes:
- Backend resource cleanup: async shutdown() method
- Screenshot cleanup: lifecycle management for matplotlib figures

All changes syntax-validated and runtime-tested via headless demo.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fix Windows supervisor process liveness check
cde1a96 
Use process handles rather than os.kill(pid, 0) on Windows, where zero can generate a console control event. Add a regression test that prevents use of os.kill on Windows.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@vitungduonngg

vitungduonngg commented Oct 3, 2026

Copy link
Copy Markdown
Author

GitHub đang để workflow tests ở trạng thái Action required; vui lòng approve workflow run của PR #1

@vitungduonngg
vitungduonngg deleted the vitungduonngg-curly-waffle branch October 3, 2026 01:01
@vitungduonngg

vitungduonngg commented Oct 3, 2026

Copy link
Copy Markdown
Author

Hi, I opened PR #1 from my fork vitungduonngg/AutoCAD-MCP to beiming183-cloud/AutoCAD-MCP. GitHub Actions shows Action required, and the Checks page says “Workflow runs completed with no jobs,” so CI tests have not actually run. Could you check the fork PR’s workflow permissions and approve/enable the tests workflow? Thanks!

PR: [beiming183-cloud/AutoCAD-MCP#1](#1)

@vitungduonngg
vitungduonngg restored the vitungduonngg-curly-waffle branch October 3, 2026 01:13
@vitungduonngg
vitungduonngg deleted the vitungduonngg-curly-waffle branch October 3, 2026 01:13
@vitungduonngg

vitungduonngg commented Oct 3, 2026

Copy link
Copy Markdown
Author

Hi, I opened PR #1 from my fork vitungduonngg/AutoCAD-MCP to beiming183-cloud/AutoCAD-MCP. GitHub Actions shows Action required, and the Checks page says “Workflow runs completed with no jobs,” so CI tests have not actually run. Could you check the fork PR’s workflow permissions and approve/enable the tests workflow? Thanks!

PR: [beiming183-cloud/AutoCAD-MCP#1](#1)

@vitungduonngg
vitungduonngg restored the vitungduonngg-curly-waffle branch October 3, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vitungduonngg