Skip to content

feat: LINE QR Login as Primary login - #259

Merged
highesttt merged 3 commits into
mainfrom
highest/plat-39178
Oct 6, 2026
Merged

highesttt merged 3 commits into
mainfrom
highest/plat-39178

Conversation

@highesttt

Copy link
Copy Markdown
Collaborator

No description provided.

@indent

indent Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Issues

All clear! No issues remaining. 🎉

1 issue already resolved
  • LineQRLogin.StartWithOverride copies only ExistingLogin, ExistingMetadata and Certificate into the wrapped LineEmailLogin, so finishLogin builds new metadata with empty Email/Password. A user who re-authenticates via QR loses stored credentials, and tryLogin then fails with "no stored credentials available for re-login". (fixed by commit aa35008)
    Found by Indent Review Agent

CI Checks

All CI checks passed on 22dca1a.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No new issues in the QR re-login commit; earlier finding remains fixed.
Full results

Indent Review Agent

  • Summary: No new issues in the QR re-login commit; earlier finding remains fixed.
  • Last ran on commit: 22dca1a9
  • Latest result
    {
      "summary": "No new issues in the QR re-login commit; earlier finding remains fixed.",
      "findings": []
    }

Comment thread pkg/connector/login_qr.go
@highesttt
highesttt merged commit 03371e6 into main Oct 6, 2026
9 checks passed
@highesttt
highesttt deleted the highest/plat-39178 branch October 6, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant