Skip to content

fix: Chat deletion support - #258

Merged
highesttt merged 3 commits into
mainfrom
highest/plat-39165
Oct 6, 2026
Merged

highesttt merged 3 commits into
mainfrom
highest/plat-39165

Conversation

@highesttt

Copy link
Copy Markdown
Collaborator

No description provided.

@linear-code

linear-code Bot commented Oct 6, 2026

Copy link
Copy Markdown

PLAT-39165

@indent

indent Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Issues

All clear! No issues remaining. 🎉

3 issues already resolved
  • Deleting a pending LINE group invitation (a Beeper message request) finds no message box, so it saves cutoff "0" and returns success without calling LINE. The invitation stays pending on LINE, and syncChatsNow then hides it forever. Reject the invitation via RejectChatInvitation, as HandleMatrixLeaveRoom does, when the portal is a message request. (fixed by commit cffc8d6)
    Found by Indent Review Agent
  • syncChatsNow calls shouldSkipDeletedChat(chat.ChatMid, ""), and an empty ID never parses, so it skips every chat with a stored cutoff. A deleted group that gets new messages therefore never gets its ChatResync pre-creation, and the first queued message creates the portal with spurious "joined the chat" events. (fixed by commit cffc8d6)
    Found by Indent Review Agent
  • If a deleted group gets a new message while the bridge is running, queueIncomingMessage creates the portal from that message. This skips the pre-creation ChatResync used by syncChatsNow, so existing members show as fresh "joined the chat" events. It's cosmetic and happens once per reopened group. (fixed by commit f408abb)
    Found by Indent Review Agent

CI Checks

All CI checks passed on f408abb.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No new bugs; the GetChatInfo strip is redundant and my earlier nit was wrong.
Full results

Indent Review Agent

  • Summary: No new bugs; the GetChatInfo strip is redundant and my earlier nit was wrong.
  • Last ran on commit: f408abb3
  • Latest result
    {
      "summary": "No new bugs; the GetChatInfo strip is redundant and my earlier nit was wrong.",
      "findings": []
    }

Comment thread pkg/connector/delete_chat.go
Comment thread pkg/connector/sync.go
@highesttt
highesttt merged commit 5ab0227 into main Oct 6, 2026
9 checks passed
@highesttt
highesttt deleted the highest/plat-39165 branch October 6, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant