Repository navigation
Use published mautrix cancellation admission fix - #257
Closed
iFixRobots wants to merge 1 commit into
Closed
iFixRobots wants to merge 1 commit into
iFixRobots wants to merge 1 commit into
Conversation
|
No issues found.
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume the owning framework fix in #255, so canceled login attempts queued behind mautrix's cache lock are rejected before cached state replacement.
The patched framework is published as the independent
github.com/beeper/line/mautrixsubmodule on isolated hosting branches, not LINE's normal source branch. Pinv0.0.0-20261005154202-36ea6b3ea505through an explicit replacement for canonicalmaunium.net/go/mautrix. Its subtree exactly matches upstreamf14e6b5fplus the six-line admission fix; the upstream license and complete source/schema/fixture tree are preserved.Update the canonical requirement to that upstream baseline and tidy the selected framework dependency graph. This intentionally moves the standalone LINE app from the older mautrix 0.29 snapshot to the tested 0.31 baseline. The hosting submodule is not copied into this branch.
Validation
The complete LINE stack passed all existing tests, the bridge build, scoped vet/staticcheck and diff checks with Go 1.27.1 and native inlining disabled against the exact published replacement. Go confirmed the selected module resolves from GitHub, not a local path. The framework's queued-cancellation diagnostic and bridgev2 checks also passed.
No generated-code edits, new regression tests, inline comments, live login handshake, deployment, account reset or test send. No race-suite pass is claimed. Admission checks do not make an already-admitted login transaction reversible.
Stacked after #250 → #251 → #252 → #253 → #254. Framework #255 targets only its temporary hosting base. Megabridge #39 must also declare the framework replacement because dependency-module replacements are not inherited.
Return to the canonical upstream module after a normal upstream contribution route is available and the fix lands. Keep the hosting commit reachable while consumers pin it.
Tag
@indentto continue the conversation here.