Skip to content

Use published mautrix cancellation admission fix - #257

Closed
iFixRobots wants to merge 1 commit into
iFixRobots/isolate-group-key-wrappingfrom
iFixRobots/use-patched-mautrix-login-admission
Closed

iFixRobots wants to merge 1 commit into
iFixRobots/isolate-group-key-wrappingfrom
iFixRobots/use-patched-mautrix-login-admission

Conversation

@iFixRobots

Copy link
Copy Markdown
Contributor

Consume the owning framework fix in #255, so canceled login attempts queued behind mautrix's cache lock are rejected before cached state replacement.

The patched framework is published as the independent github.com/beeper/line/mautrix submodule on isolated hosting branches, not LINE's normal source branch. Pin v0.0.0-20261005154202-36ea6b3ea505 through an explicit replacement for canonical maunium.net/go/mautrix. Its subtree exactly matches upstream f14e6b5f plus the six-line admission fix; the upstream license and complete source/schema/fixture tree are preserved.

Update the canonical requirement to that upstream baseline and tidy the selected framework dependency graph. This intentionally moves the standalone LINE app from the older mautrix 0.29 snapshot to the tested 0.31 baseline. The hosting submodule is not copied into this branch.

Validation

The complete LINE stack passed all existing tests, the bridge build, scoped vet/staticcheck and diff checks with Go 1.27.1 and native inlining disabled against the exact published replacement. Go confirmed the selected module resolves from GitHub, not a local path. The framework's queued-cancellation diagnostic and bridgev2 checks also passed.

No generated-code edits, new regression tests, inline comments, live login handshake, deployment, account reset or test send. No race-suite pass is claimed. Admission checks do not make an already-admitted login transaction reversible.

Stacked after #250 → #251 → #252 → #253 → #254. Framework #255 targets only its temporary hosting base. Megabridge #39 must also declare the framework replacement because dependency-module replacements are not inherited.

Return to the canonical upstream module after a normal upstream contribution route is available and the fix lands. Keep the hosting commit reachable while consumers pin it.

View in Indent
Tag @indent to continue the conversation here.

@indent

indent Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Issues

No issues found.

CI Checks

Build 1.26 failed because proxy.golang.org returned a stream INTERNAL_ERROR while downloading golang.org/x/text@v0.42.0. It looks transient, not caused by the PR.

Failing Build 1.26
  • The job failed during module download, before compiling. The log shows: read "https://proxy.golang.org/golang.org/x/text/@v/v0.42.0.zip": stream error: INTERNAL_ERROR; received from peer. The replaced mautrix module (github.com/beeper/line/mautrix) and all other modules downloaded fine. Re-running the job should clear it. If it fails again, check that x/text v0.42.0 is available on the proxy.

Review agents

Select any unchecked box below to run or rerun that agent.

Pending (1)
  • Indent Review Agent · Review in progress; no result yet.
Full results

Indent Review Agent

  • Summary: Review in progress; no result yet.
  • Latest resultNo result yet — review in progress.

@indent indent Bot closed this Oct 5, 2026
@indent
indent Bot deleted the iFixRobots/use-patched-mautrix-login-admission branch October 5, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant