fix: abort handler manually after abnormal closure#40
Open
nichtsen wants to merge 1 commit intobeego:masterfrom
Open
fix: abort handler manually after abnormal closure#40nichtsen wants to merge 1 commit intobeego:masterfrom
nichtsen wants to merge 1 commit intobeego:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i had ran the chatroom example on my local machine, however, when user closed the tab on browser, the handler just crashed with the following logs:
`[panic.go:838] the request url is /ws/join
[panic.go:838] Handler crashed with error can't find templatefile in the path:views/websocketcontroller/join.tpl
`
it seems that
beegotrys to find template and render after/ws/joinhandler return, which is not neccessary in the case. Instead, abort handler manually is suitable.