Skip to content

fix: change vue icon to nf-seti-vue since nf-mdi-vuejs(\ufd42) is aba… - #26

Open
Rogerskelamen wants to merge 1 commit into
beauwilliams:masterfrom
Rogerskelamen:fix-vue-icon
Open

fix: change vue icon to nf-seti-vue since nf-mdi-vuejs(\ufd42) is aba…#26
Rogerskelamen wants to merge 1 commit into
beauwilliams:masterfrom
Rogerskelamen:fix-vue-icon

Conversation

@Rogerskelamen

@Rogerskelamen Rogerskelamen commented Oct 22, 2025

Copy link
Copy Markdown

Hi, since the nerdfont upgraded to 3.4.0v, the icon nf-mdi-vuejs is no longer available. So I just changed the vue icon from nf-mdi-vuejs to nf-seti-vuejs(which is the default vue icon in web-devicons).
image

I’ve been using this status line for about 3 years, so I’d really appreciate it if you could keep maintaining it and keeping it up to date over time.

Thanks for your great work, have a nice day~

Summary by CodeRabbit

  • Style
    • Updated the icon representation for Vue files in the user interface.

@coderabbitai

coderabbitai Bot commented Oct 22, 2025

Copy link
Copy Markdown

Walkthrough

Updated the icon glyph mapping for Vue file extensions in the icon lookup table from "﵂" to "". This is a cosmetic configuration change with no impact on control flow or functionality.

Changes

Cohort / File(s) Summary
Icon mapping updates
lua/tables/_icons.lua
Changed Vue extension icon glyph from "﵂" to "" in the extensionTable lookup

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A glyph for Vue has changed its face,
From curious mark to a cleaner place,
One swift update, so light and lean,
The prettiest icons you've ever seen! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "fix: change vue icon to nf-seti-vue since nf-mdi-vuejs(\ufd42) is aba…" directly corresponds to the main change in the pull request. The changeset modifies the icon mapping for the Vue extension from the old nf-mdi-vuejs icon to nf-seti-vue, which aligns precisely with the title's description. The title is specific and clear—it identifies what changed (the Vue icon), the new value (nf-seti-vue), and provides context for the reason (nf-mdi-vuejs is no longer available after the nerdfont upgrade). A developer scanning the repository history would immediately understand the purpose and scope of this change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c7083c and c0fa15c.

📒 Files selected for processing (1)
  • lua/tables/_icons.lua (1 hunks)
🔇 Additional comments (1)
lua/tables/_icons.lua (1)

136-136: LGTM! Icon update is complete and aligns with NerdFont 3.4.0 changes.

The change correctly replaces the removed nf-mdi-vuejs icon with nf-seti-vuejs. Verification confirms no lingering references to the old icon glyph elsewhere in the codebase—the update is clean and isolated to this single line.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant