ci: give the link check retries and a wider timeout - #4
Merged
Conversation
The check failed on a branch whose links were all fine: four timeouts against contributor-covenant.org and zero errors. A third-party host having a slow minute should not be indistinguishable from a dead link. Retries and a 30s timeout absorb that. A link that is genuinely gone still fails the build, which is the only reason the check exists. Spec: GOV-R12 Signed-off-by: Wessel Verheij <info@nightworks.io>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hygiene / linksfailed on a branch whose links were all fine: four timeouts againstcontributor-covenant.org, zero errors. A third-party host having a slow minute should not be indistinguishable from a dead link.--max-retries 5 --retry-wait-time 3 --timeout 30absorbs that. A link that is genuinely gone still fails the build.Spec: GOV-R12