Repository navigation
fix: replace HTML comment stripping in Octane test - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Octane DOM-binding test removed HTML comments with a regex that can recreate comment markers when matches are deleted, triggering CodeQL alert #4. Parse the rendered HTML with the existing happy-dom dependency and assert the output element's text directly, closing the window afterward.
Addresses https://github.com/beastjs/beast/security/code-scanning/4.
Validation:
bun test tests/octane-0.8.test.ts— 27 tests passed.bun run typecheck— passed across all packages.git diff --check— passed.