Skip to content

ci: publish GitHub-attested binary releases - #15

Open
beardedeagle wants to merge 3 commits into
mainfrom
release-pipeline
Open

beardedeagle wants to merge 3 commits into
mainfrom
release-pipeline

Conversation

@beardedeagle

@beardedeagle beardedeagle commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Publish version-tag and manual binary releases for Postmaster's five Linux/macOS targets. Each target runs release-profile tests, packages the binary and license, smoke-tests the extracted binary, and generates a GitHub build attestation.

The publisher requires the complete target set, binds the tag and source commit in release.json, and attests that metadata and the SHA-256 manifest. It downloads every draft asset and verifies its inventory, checksums, workflow identity, triggering commit/ref, and hosted-runner provenance before publication. Existing releases cannot be replaced.

  • Use GitHub OpenID Connect attestations without managed signing keys or release secrets.
  • Restrict release tags to version-matching commits reachable from main; manual runs use the workflow on main.
  • Verify the manifest and archive before installation, accepting only the release workflow on main or version tags.
  • Run the installer regression when the release guide changes.
  • Share release checks through Justfile recipes and pin official actions to full release commits.
  • Require both Linux and macOS Quality checks on main.

How was this verified?

  • All eight release-tool tests pass. They cover source authorization, complete inventories, altered archives/metadata, missing downloads, rejection of each of the seven assets' attestations, tag/manual provenance constraints, and fail-fast installation.
  • The installation example's identity policy rejects pull requests, feature branches, other repositories, and crafted ref suffixes.
  • Commit and push hooks pass: 186 native Rust tests, formatting, native/release/Linux Clippy, a locked build, cargo-deny, cargo-audit, and Markdown lint.
  • Actionlint, ShellCheck, Ruff, and mdBook pass. The existing mdbook-mermaid version warning remains.
  • The combined changes from this PR and ci: publish documentation through GitHub Pages Actions #14 merge cleanly.
  • All eleven active hosted checks pass on 6d6e28f: both Quality jobs, both Nix jobs, Docs, release validation, and all five release builds. The publisher is intentionally skipped on PRs. Actual OIDC attestation generation and public publication require a tag/manual release run.

Checklist

  • The diff is focused.
  • just ci-rust passes locally.
  • Release-tool regression tests pass.
  • just docs succeeds and describes the release workflow.
  • Latest-head hosted checks pass.
  • Commit message has an imperative subject.
  • I have read the contributing guidelines.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 18:04
@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with ci:, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release instructions can continue to extract and install an archive after verification fails, potentially installing a rejected archive while reporting success.

1 open issue
What changed in this PR

Adds a binary-release pipeline for Postmaster’s five Linux and macOS targets, with source validation, signed checksums, and GitHub attestations.

Changes:

  • Builds, tests, packages, and attests binaries for tag and manual releases, with unsigned pull-request previews.
  • Signs release metadata and verifies downloaded draft assets before publication.
  • Adds release-tool tests, shared Justfile recipes, and setup and installation documentation.
File Description
README.md Links to the release guide.
Justfile Adds shared release build, signing, and verification recipes.
docs/​src/​SUMMARY.md Adds release documentation to navigation.
docs/​src/​development/​releases.md Documents signing setup, publication, and consumer verification.
CHANGELOG.md Records the new release pipeline.
.github/​workflows/​release.yml Orchestrates source validation, five-target builds, and publication.
.github/​release/​test_release.py Tests source restrictions, integrity checks, and publication safeguards.
.github/​release/​sign.sh Signs checksums with the dedicated Minisign key.
.github/​release/​release.py Validates sources, packages binaries, and verifies manifests.
.github/​release/​publish.sh Verifies downloaded draft assets before publishing.
.github/​release/​install-minisign.sh Installs Minisign after checking its archive digest.
.github/​CONTRIBUTING.md Documents release-tool checks for contributors.

Review effort: Balanced

Comment thread docs/src/development/releases.md Resolved
@beardedeagle beardedeagle changed the title ci: publish signed and attested binary releases ci: publish GitHub-attested binary releases Nov 12, 2026
@beardedeagle
beardedeagle requested a balanced review from Copilot November 12, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Without independent tag-creation restrictions, a tagger can remove the workflow’s ancestry check and mint installer-trusted attestations from an unmerged commit.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment on lines +4 to +5
push:
tags: ["v*"]

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants