Track impellerc and an engine stamp as shader bundle build inputs - #22
Merged
Conversation
Shader bundles are tied to the engine build that supplied impellerc, but the hook's declared inputs only covered the manifest and shader sources, so engine changes within a Dart SDK version left stale bundles in place, and the pub-cache output path let projects on different SDKs overwrite each other's bundle undetected. Declare the impellerc binary as a build dependency and write a content-addressed engine stamp beside each bundle so either change reruns the hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shader bundles are tied to the engine build that supplied impellerc, but the hook only declared the manifest and shader sources as inputs, so an engine change within a single Dart SDK version left stale bundles in place, and the shared pub-cache output path let projects on different Flutter SDKs overwrite each other's bundle undetected. impellerc is now a content-hashed build dependency, and a write-if-changed engine stamp beside each bundle turns a foreign rewrite into a hook rerun.