Open
Conversation
vr16x
requested review from
alexcambose,
fichiokaku and
filmakarov
and removed request for
filmakarov
size-limit report 📦
|
alexcambose
reviewed
Jul 4, 2025
|
|
||
| console.log("trigger.amount", trigger.amount) | ||
| console.log("fusionQuote.trigger.amount", fusionQuote.trigger.amount) | ||
| console.log(getMeeScanLink(fusionQuote.quote.hash)) |
| }) | ||
|
|
||
| const quote = await meeClient.getQuote({ | ||
| instructions: [...transferInstruction, ...instructions, ...instructions], |
Contributor
There was a problem hiding this comment.
should these ...instructions be added 2 times?
Collaborator
Author
There was a problem hiding this comment.
Yeah, it is part of the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces a new
merkle-treeutility, updates theDEFAULT_PREFIXto be exported, and modifies thesponsorSupertransactionfunction to utilize the newcreateMerkleTreefunction for signature verification. Additionally, it increases the size limit and updates some dependencies.Detailed summary
merkle-treeinsrc/sdk/modules/utils/index.ts.DEFAULT_PREFIXto be an exported constant insrc/sdk/clients/decorators/mee/signQuote.ts.createMerkleTreeinsrc/sdk/modules/utils/merkle-tree.ts.sponsorSupertransactionto usecreateMerkleTreefor signature verification.size-limit.jsonfrom65 kBto98 kB.package.jsonfor@openzeppelin/merkle-tree,@vitest/coverage-istanbul, andvitest.