Fix flaky CI tests on Node.js 18: increase async assertion timeouts#14
Merged
Conversation
…der load Agent-Logs-Url: https://github.com/bchr02/filejson/sessions/d71dfac2-c49b-43e4-a39a-7ce28e77b53a Co-authored-by: bchr02 <10158167+bchr02@users.noreply.github.com>
…unners Agent-Logs-Url: https://github.com/bchr02/filejson/sessions/d71dfac2-c49b-43e4-a39a-7ce28e77b53a Co-authored-by: bchr02 <10158167+bchr02@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bchr02/filejson/sessions/d71dfac2-c49b-43e4-a39a-7ce28e77b53a Co-authored-by: bchr02 <10158167+bchr02@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bchr02
April 30, 2026 21:11
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7 tests failed intermittently on the Node.js 18 CI job because assertion timers fired before atomic write operations (temp file write + rename) completed on a loaded runner. Node.js 20/22 passed consistently.
Changes
test/filejson.test.js— Increased assertion wait times for the 7 affected tests to provide adequate margin for async I/O under CI load:should respect custom space configurationshould handle number valuesshould handle array valuesshould only save once after multiple rapid changesshould work with custom saveDelay of 200ms(late check)should debounce with Promise API(late check)should use atomic writes by defaultEarly "not-yet-saved" checks in debounce tests are unchanged — they still fire well within the
saveDelaythreshold.