Skip to content

Python313 consolodate dbc#4441

Closed
loneil wants to merge 3 commits into
bcgov:mainfrom
loneil:python313ConsolodateDbc
Closed

Python313 consolodate dbc#4441
loneil wants to merge 3 commits into
bcgov:mainfrom
loneil:python313ConsolodateDbc

Conversation

@loneil
Copy link
Copy Markdown
Collaborator

@loneil loneil commented May 28, 2026

Issue #: /bcgov/entity###

Description of changes:
This will be dependent on #4440

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

kialj876 and others added 3 commits May 20, 2026 17:02
* Initial commit - Python 3.13, major deps, major flows passed manual testing, unit tests setup broken

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* interim commit - over 80% of tests passing

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* interim commit - fixes for meta, naics, and authorization tests

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* All tests passing except a couple

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Fixed remaining tests

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* cleanup

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: lint fixes

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* sonar cloud reliability

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: rebase

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore lint warnings

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: update model dep for consolidation comments

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: cleanup for green CI

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: poetry lock for lxml dep update

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

---------

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* 33245 Legal API - use common utils, reduce deprecation warnings

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: cleanup

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: cleanup

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: update lock file

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* chore: fix typing on sonar cloud issue

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

---------

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Lucas <lucasoneil@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@loneil
Copy link
Copy Markdown
Collaborator Author

loneil commented May 28, 2026

Wrong target branch

@loneil loneil closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants