Button: add min-width and min-height#637
Merged
mkernohanbc merged 4 commits intomainfrom Mar 10, 2026
Merged
Conversation
mkernohanbc
added
the
Components
ty2k
requested changes
Mar 10, 2026
Contributor
ty2k
left a comment
ty2k
left a comment
There was a problem hiding this comment.
Nice this totally solves the touch target accessibility piece for size: xsmall buttons! ✅
A couple minor CSS requests below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue identified by @ty2k in #633. With the introduction of the
xsmallbutton variant in 0.5.2, we inadvertently made it possible to violate WCAG SC 2.5.8. Anxsmallbutton with a single-character label fails to meet the minimum target size:This change resolves this by setting
min-widthandmin-heightat the top level of the component. It also cleans up some inconsistency/duplication in various rules.