33227 create/update Authentication and Certification component#486
Conversation
eve-git
requested review from
deetz99,
doug-lovett and
vysakh-menon-aot
as code owners
|
/gcbrun |
eve-git
requested review from
Copilot
and removed request for
deetz99,
doug-lovett and
vysakh-menon-aot
|
Temporary Url for review: https://business-registry-home-dev--pr-486-w1eeq9z1.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-486-hsdcs1g6.web.app |
|
Temporary Url for review: https://business-people-dev--pr-486-eyp6n5ys.web.app |
There was a problem hiding this comment.
Pull request overview
This PR updates the shared base filing authorization/certification UI, adding a new Confirm Authorization form component and simplifying the existing Certify component to checkbox-only authorization text.
Changes:
- Adds
FormConfirmAuthorizationwith schema, translations, and playground example. - Updates
FormCertifyand its schema/translations to remove the legal name input and use new authorization copy. - Adds playground navigation entries and updates e2e certify helper behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/layers/base/tests/e2e/test-utils/fill-out-certify.ts |
Updates certify test helper to only check the certification checkbox. |
packages/layers/base/i18n/locales/en-CA.ts |
Adds labels, authorization text, descriptions, and validation copy. |
packages/layers/base/app/utils/schemas/index.ts |
Exports the new confirm authorization schema. |
packages/layers/base/app/utils/schemas/confirm-authorization.ts |
Adds schema and component ref type for confirm authorization. |
packages/layers/base/app/utils/schemas/certify.ts |
Simplifies certify schema to checkbox validation only. |
packages/layers/base/app/components/Form/ConfirmAuthorization/index.vue |
Adds the new confirm authorization form component. |
packages/layers/base/app/components/Form/Certify/index.vue |
Refactors certify UI and removes legal name collection. |
packages/layers/base/.playground/i18n/locales/en-CA.ts |
Removes obsolete playground-only certify description copy. |
packages/layers/base/.playground/app/pages/index.vue |
Adds playground links for Certify and Confirm Authorization examples. |
packages/layers/base/.playground/app/pages/examples/components/Form/ConfirmAuthorization/default.vue |
Adds a playground example page for Confirm Authorization. |
packages/layers/base/.playground/app/pages/examples/components/Form/Certify/default.vue |
Updates the Certify playground example for the new component API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-486-w1eeq9z1.web.app |
|
Temporary Url for review: https://business-people-dev--pr-486-eyp6n5ys.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-486-hsdcs1g6.web.app |
|
Since we do not have a temp url for the base layer currently can you please include some screenshots of the components and their different states, blank, filled, error, staff vs non-staff, etc. Also FormCertify is currently used in Dissolution, Transition and Correction. Do any of these need to be updated? |
|
I think https://app.zenhub.com/workspaces/colin-egress-team-6904d552be2bb0000fa13ad6/issues/gh/bcgov/entity/33079 is for the other updates |
|
Okay in that case can you please also open up tickets to add/update the correct component to Transition and Corrections? |
|
These error states look a bit off. Please review the Figma. |
|
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-486-w1eeq9z1.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-486-hsdcs1g6.web.app |
|
Temporary Url for review: https://business-people-dev--pr-486-eyp6n5ys.web.app |
|
/gcbrun |
|
Temporary Url for review: https://business-people-dev--pr-486-eyp6n5ys.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-486-hsdcs1g6.web.app |
|
Temporary Url for review: https://business-registry-home-dev--pr-486-w1eeq9z1.web.app |
|
Looking pretty good, just a lint error to clean up 🙏 |
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-486-w1eeq9z1.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-486-hsdcs1g6.web.app |
|
Temporary Url for review: https://business-people-dev--pr-486-eyp6n5ys.web.app |
deetz99
left a comment
deetz99
left a comment
There was a problem hiding this comment.
Looks good 🎉
Please open 2 tickets in the product backlog for updating the Transition and Correction filing with these new components 🙏
Issue #: /bcgov/entity#33421
Description of changes:
create/update Authentication and Certification component
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-ui license (BSD 3-Clause).