33467: force baseAddress to reject non-latin-1 on address fields#313
Merged
mruff-aeq merged 2 commits intoMay 19, 2026
Merged
Conversation
kialj876
reviewed
May 19, 2026
Collaborator
kialj876
left a comment
kialj876
left a comment
There was a problem hiding this comment.
Looks good, but can you update the storybook to include the new prop please?
Collaborator
Author
|
@
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33467 : /bcgov/entity#33467
Description of changes:
Added a new requireLatin1 prop to the BaseAddress component that, when enabled, applies a validation rule to all address text fields to ensure only Latin-1 (ISO-8859-1) characters are accepted. This allows for standard alphanumeric and accented characters while proactively rejecting non-Latin scripts like CJK or Hindi during entry or paste.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).