Skip to content

Reorganize docs folder into guides, architecture, features, and research#1750

Open
johan-bell wants to merge 2 commits into
mainfrom
1749-docs-reorganizing-documents-of-the-project
Open

Reorganize docs folder into guides, architecture, features, and research#1750
johan-bell wants to merge 2 commits into
mainfrom
1749-docs-reorganizing-documents-of-the-project

Conversation

@johan-bell

Copy link
Copy Markdown
Collaborator

Move flat docs/ files into a clearer hierarchy, add docs/README.md index, archive historical-upgrades stub, consolidate project-automation guide, and update cross-repo references to the new paths.

@ivanslabbert

Copy link
Copy Markdown
Contributor

Review summary — 🟡 Approve with nits

Clean, well-executed docs reorg; two pre-existing broken links carried forward rather than fixed.

  • Reorg goals met. Flat docs/ files moved into a sensible guides/ · architecture/ · features/ · research/ · archive/ hierarchy; new docs/README.md index is accurate and every link target exists; historical-upgrades stub and project-automation guide added; all 5 renamed diagrams + rest-api image reference (./workflow.drawio.png) resolve.
  • No stale old-path references remain. Grep for old flat paths (docs/restApi.md, docs/translations.md, docs/vue-plugin-architecture/…, etc.) across .md/.ts/.vue/.json returns nothing; code comment refs in permissions.service.ts and CLAUDE.md/README.md updates point at the new locations.
  • Nit (pre-existing, not a regression): broken app/README.md links. docs/features/vue-plugin-architecture/README.md:8 and .../plugin-system-explained.md:137 use ../../../../app/README.md (4× ../) which resolves above the repo root — correct depth for the new location is 3 (../../../app/README.md). These were already off-by-one on main; the move bumped the count but kept the error.
  • Nit (pre-existing, now a broken md link): automate-luminary.sh. New docs/guides/project-automation.md:30 links [scripts/automate-luminary.sh](../../scripts/automate-luminary.sh), but no such file exists — the actual script is scripts/setup-dev.sh. This name mismatch already exists in CLAUDE.md:20 and scripts/README.md, but this PR turns it into a clickable broken link.
  • Suggestion. While touching these lines anyway, fix the ../ count (→ ../../../app/README.md) and either point the automation guide at setup-dev.sh or reconcile the CLI name repo-wide. Neither blocks merge.

🤖 AI-assisted review summary (Claude Code). Read-only analysis of the PR diff — not a substitute for human review.

Move flat docs/ files into a clearer hierarchy, add docs/README.md index,
archive historical-upgrades stub, consolidate project-automation guide, and
update cross-repo references to the new paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
@johan-bell johan-bell force-pushed the 1749-docs-reorganizing-documents-of-the-project branch from 55cc4ca to 3db899d Compare July 6, 2026 09:49

@ivanslabbert ivanslabbert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments. But I think we should generally move away from a separate docs folder (except perhaps for a few diagrams like the data model, permission system etc. diagrams).

Documentation describing the actual implementation should live in the app / cms / api / shared library codebases, referenced from the main README of the individual folder.

The projects root level's README serves as the springboard into all the sub-project's documentation, and everything should be reachable by drilling down into sub-project readme files, and drilling down into individual functions

Comment thread docs/guides/project-automation.md Outdated
Comment thread docs/research/fts/README.md Outdated
Comment thread cms/README.md Outdated
…cross-cutting content

Per Ivan's review: docs/ now holds only ADRs, cross-cutting guides, and
architecture diagrams. Vue-plugin-architecture moves to app/docs/,
rest-api/socket-io-messages/s3-multi-bucket move to api/docs/,
api-testing folds into api/README.md, the stale post-checkout git-hook
doc is removed (hook script was already deleted from the repo), and
docs/research/fts/ (superseded by ADR 0009) is deleted.

@MrDirkelz MrDirkelz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: reorganizing documents of the project

3 participants