Repository navigation
Fix temporary audio cleanup after failures - #72
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed audio comparisons leave temporary WAV files behind.
find_offset_between_files()only deletes the files after a successful result, so a failure converting the second input, reading a WAV, or analyzing short audio skips cleanup. FFmpeg can also leave a partial output when conversion fails.Register each successfully converted file for cleanup immediately, using
ExitStack, and remove partial output when conversion raises. Existing error messages and returned offset results are preserved.Four regression cases fail before the fix and pass afterward. They check conversion, reading, and analysis failures, including preserving the original exception and deleting partial FFmpeg output. The full suite passes on Linux with Python 3.12 and real FFmpeg: 11 passed. Black reports both changed files unchanged.