Repository navigation
Fix the earliest negative correlation offset - #70
Merged
Merged
Conversation
Contributor
|
LGTM. @chrisn? |
Member
|
Thank you for contributing @Shubham-Padkonde. And thank you for reviewing, @elvum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the strongest match occurs at the earliest negative offset,
find_offset_between_buffersreports a positive offset instead. The boundary returned bycross_correlationis exclusive, as also used by the plotting code'srange, but the wraparound check uses>rather than>=.Include that boundary in the negative-offset conversion. A deterministic regression uses matching feature frames and the real standardization/correlation code: it reports +21 frames before the fix and the correct -10 frames afterward.
Validation: all seven tests pass under Linux with FFmpeg, including the existing audio-file and CLI tests. Black and
git diff --checkpass.