Repository navigation
Speed up cross-correlation with FFT convolution - #69
Merged
Merged
Conversation
Contributor
Author
|
@stephenjolly |
Member
|
Thanks for this, looks like a nice improvement! The CI tests were failing, so I've just fixed those. Would you mind rebasing this branch on top of the latest master branch so we can verify all the checks are passing? |
This replaces the O((n1 + n2) * nframes * numcep) sequential offset scan with O((n1 log n1 + n2 log n2) * numcep) FFT convolution.
comavius
force-pushed
the
use-fft-convolution
branch
from
September 21, 2026 06:30
db2a5c9 to
b56efb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the O((n1 + n2) * nframes * numcep) sequential offset scan with O((n1 log n1 + n2 log n2) * numcep) FFT convolution.
Benchmarking
I compared the execution time of
find_offset_between_buffersbetween this branch and the main branch.The benchmark uses the full 1812 Overture audio as the reference buffer and the same audio with the first 10 seconds removed as the comparison buffer. Each implementation was run 50 times in shuffled order after decoding the audio once.
The audio file is available on Wikimedia Commons:
https://commons.wikimedia.org/wiki/File:Pyotr_Ilyich_Tchaikovsky_-_1812_overture.ogg