Properly handle artifact_name_patterns#3784
Open
dzbarsky wants to merge 3 commits intobazelbuild:mainfrom
Open
Properly handle artifact_name_patterns#3784dzbarsky wants to merge 3 commits intobazelbuild:mainfrom
dzbarsky wants to merge 3 commits intobazelbuild:mainfrom
Conversation
UebelAndre
requested changes
Dec 19, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Is there a test you can add for this? Or is it specific to mingw toolchains?
dzbarsky
force-pushed
the
zbarsky/windows-names
branch
from
02061f2 to
643f750
Compare
Contributor
Author
OK I don't think there's a lot of value in testing this given everything continues to work and it's more correct by inspection, but added. |
dzbarsky
force-pushed
the
zbarsky/windows-names
branch
from
643f750 to
bebd71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using cc_common.link, the output's name will default to whatever the cc_toolchain infers from
artifact_name_patterns. Since rust doesn't respect that, we need to force the name to match the output we want to generate.Without this, cc_common.link + Windows is sadness