fix(CDC): append chunks when downloading path-backed outputs#29545
Closed
tyler-french wants to merge 1 commit into
Closed
fix(CDC): append chunks when downloading path-backed outputs#29545tyler-french wants to merge 1 commit into
tyler-french wants to merge 1 commit into
Conversation
fmeum
reviewed
May 15, 2026
eb4afad to
3bbc53b
Compare
3bbc53b to
0152704
Compare
Contributor
|
@bazel-io 9.1.1 |
Member
|
@tyler-french 9.1.0 is already released. Let's also wait until it is merged to the master branch first before we merge this to the release branch because we prefer the cherry-pick bot to do the work. I will reopen this if there's a merge conflict and help is needed. Thank you! |
Contributor
Author
EDIT: Thanks, just realized #29341 IS going into 9.1.1. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29544
Using
--remote_download_outputs=toplevelwith--experimental_remote_cache_chunkingand--disk_cachecan cause Bazel to materialize a top-level output as a single CDC chunk instead of the full blob. This happens because the chunked downloader passes the final path-backed output stream into per-chunk downloads, lettingDiskCacheClient'sMaybePathBackedfast path copy each cached chunk directly over the final output path.This PR fixes it by fetching each chunk through
CombinedCacheas bytes and then appending those bytes to the final output stream, preserving disk cache policy/write-through behavior for chunks while keeping the path-backed copy optimization for whole-blob downloads.This is unintentionally fixed in #29341
But I think this might be worth a patch release in 9.1.1 and/or 8.7.1