[9.1.0] Migrate from URL to URI#28802
Merged
meteorcloudy merged 3 commits intobazelbuild:release-9.1.0from Feb 27, 2026
Merged
Conversation
…ld#28347) When a mirror URL fails with an SSLException (e.g. expired certificate), the downloader should fail over to the next mirror immediately instead of retrying the failing URL multiple times. Fixes bazelbuild#28158 RELNOTES: Bazel now fails over immediately to mirror URLs if a TLS handshake error occurs. CC @lberki @fmeum @Wyv Closes bazelbuild#28347. PiperOrigin-RevId: 861936486 Change-Id: If40b966224c1e0687dd258adb2c03bbf055b8c40
You can now set the `--downloader_config` flag multiple times to specify several downloader config files at once. Fixes bazelbuild#13131 --- An initial refactoring was done to clean up unused arguments in `UrlRewriter`. Closes bazelbuild#27877. PiperOrigin-RevId: 842125029 Change-Id: Ic851d9dd7e0e2505125459d7fda5a32946cec263
The `URL` class is a legacy concept and a performance footgun as its `equals`/`hashCode` methods call out to the network. This affected the event subscriber `CacheHitReportingModule`, which stored `URL`s in a Set and thus triggered DNS resolution, even if all downloads hit the cache. While most of this change is not expected to cause any change in behavior, it has to fix a regression introduced by 8cefb8b: As of that commit, user info has no longer been forwarded to the new location requested by a redirect if the host and port stay the same. This was masked by insufficient test cases that relied on `URL#equals`, which ignores user info. Work towards bazelbuild#25068 Closes bazelbuild#28661. PiperOrigin-RevId: 871745758 Change-Id: Ib4783d28ac155315a7bcf309645118ec02ff783d
iancha1992
added
awaiting-review
meteorcloudy
approved these changes
Feb 27, 2026
Member
|
This is still draft? |
github-actions
Bot
added
the
team-Remote-Exec
Merged
via the queue into
bazelbuild:release-9.1.0
with commit Feb 27, 2026
f60e626
47 checks passed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
URLclass is a legacy concept and a performance footgun as itsequals/hashCodemethods call out to the network. This affected the event subscriberCacheHitReportingModule, which storedURLs in a Set and thus triggered DNS resolution, even if all downloads hit the cache.While most of this change is not expected to cause any change in behavior, it has to fix a regression introduced by 8cefb8b: As of that commit, user info has no longer been forwarded to the new location requested by a redirect if the host and port stay the same. This was masked by insufficient test cases that relied on
URL#equals, which ignores user info.Work towards #25068
Closes #28661.
PiperOrigin-RevId: 871745758
Change-Id: Ib4783d28ac155315a7bcf309645118ec02ff783d
Commit 5594c2a, 63f32ce, eded4bb