Create and make use of a cache for entry groups.#1558
Open
AlexanderVanhee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can save a lot of time by not having to deserialize all the entries at startup just to be able to create the entry groups.
All functionality that I tested still seems to work fine.
On my PC, the time from the init timer creation until the end of the init fiber is now around 825 ms. Ideally, I want to reduce it even further by looking for other optimizations, such as parallelizing the deserialization of the Flathub and entry group caches, or parallelizing or deferring some other tasks that happen during initialization. All for the ultimate goal of nothing having a loading timer visible to the user.