Repository navigation
Upgrade to weir-go v0.24.1 and restore previous SDK coverage - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the suite to weir-go v0.24.1, which fixes two races in the SDK's shared streams that showed up as a flaky draining-server test in weir-go itself. v0.24.0 becomes the previous SDK. It has the same API as the current one, so the adapter that bridged the API change at v0.24.0 is no longer needed.
With the adapter gone, the soak test, the independent client test and the native write evidence subtest run against the previous SDK again, which restores its coverage of streamed and query-visible writes. All three integration targets pass with no skips.